Improvents to event handling and APIs #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
October 8, 2019 18:12
edrpls
pushed a commit
that referenced
this pull request
Nov 9, 2019
* Improvents to event handling and APIs (#16) * fix typo * Update demos * Add 'Once' listener and fix setting volume * remove container contents instead of container * Retry adding stored player listeners * Fix Once listener for player * emit decorated timeupdate and refactor on/once to be reusable * Improve time reporting and player listener teardown * Support playsinline attribute and playback in iOS * GS-1222 Revert play/pause calls * Move constants to their own file * Add getCurrentTime method * GS-1230 Handle video resize event * Update readme * prepend private events with __ * prevent control's click event propagation * move defaultOptions to constants file * slightly improve docs * add MIT license * # This is a combination of 3 commits. # This is the 1st commit message: Implement VAST and VPAID support # The commit message #2 will be skipped: # add optional chaining # This is the commit message #3: split javascript from media files * Implement VAST and VPAID support split javascript from media files split other media file types add VPAIDWrapper change VAST/VPAID flow and call handshakeVersion load VPAID in FIF render and play VPAID, connect: play/pause, mute/unmute, set volume set initial volume on VPAID report VPAID playback progress await for VPAID and map events to regular events document VPAID events and changes load VPAID at the end of dummy document replace VAST request macros enable VAST playback and tracking document VAST usage and emit all VPAID events Apply muted config correctly to video elt listen for video clicks instead of container clicks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few features:
oncelistener to fire listeners onceonmethod to always return a teardown function and keep track of all active node listeners<video>tag in constructor to allow early event listeningdestroymethod now keeps the container and removes all instance and node listenersplayback-progress, player-click, resize. See README.md for details.BTW, reviewers, you don't really have to review this PR, I just wanted to keep you updated!