Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause VPAID execution until container is large enough #81

Closed
wants to merge 1 commit into from

Conversation

edrpls
Copy link

@edrpls edrpls commented Jan 24, 2020

No description provided.

@edrpls
Copy link
Author

edrpls commented Jan 24, 2020

I'm wondering if this PR should be declined; I was attempting to fix a "delay" with VPAID clickthrough becoming available, but that's just part of a specific VPAID that won't click out before two seconds have passed.

While this change should not affect anything, I'm not sure it provides much value, and may even be a hindrance since the VPAID will have to wait for its container to render before loading, that and I would prefer not adding something unless completely necessary.

@edrpls
Copy link
Author

edrpls commented Jan 24, 2020

Since the apparent delay is handled by VPAID, this PR is unnecessary.

@edrpls edrpls closed this Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant