Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/blocker div also for vpaid #86

Merged
merged 1 commit into from
May 1, 2020

Conversation

luizmendez
Copy link
Contributor

This PR adds the blocker overlay to VAST tags without VPAID in mobile.

@luizmendez luizmendez changed the base branch from master to develop May 1, 2020 01:32
Copy link

@edrpls edrpls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job and thanks for the PR!

I am yet to test the code locally, but after reviewing the code I just found some minor changes that are needed.

src/helpers/addOverlays.js Outdated Show resolved Hide resolved
src/lib/runVPAID.js Show resolved Hide resolved
@luizmendez luizmendez force-pushed the bugfix/blocker-div-also-for-vpaid branch from 6b305a2 to 2dcd3f6 Compare May 1, 2020 02:34
Copy link

@edrpls edrpls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @luizmendez! Hope this is the first of many contributions!

@edrpls edrpls merged commit fc536c2 into develop May 1, 2020
@edrpls edrpls deleted the bugfix/blocker-div-also-for-vpaid branch May 1, 2020 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants