Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nonlinear creative support #87

Merged
merged 2 commits into from
May 26, 2020
Merged

Conversation

estavillo
Copy link
Contributor

No description provided.

Copy link

@edrpls edrpls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @estavillo, it looks good, I just have a couple of questions.

src/helpers/parseVAST.js Show resolved Hide resolved
src/lib/runVPAID.js Outdated Show resolved Hide resolved
Copy link

@edrpls edrpls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @estavillo! Thanks for the contribution!

@edrpls edrpls merged commit 5003171 into develop May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants