Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Inputs with ngComponentOutlet #43

Closed
bokzor opened this issue Aug 9, 2017 · 3 comments · Fixed by #45
Closed

@Inputs with ngComponentOutlet #43

bokzor opened this issue Aug 9, 2017 · 3 comments · Fixed by #45

Comments

@bokzor
Copy link

bokzor commented Aug 9, 2017

Apparently the inputs are undefined with this syntax.

`<div *ngComponentOutlet="component"
                   [ndcDynamicInputs]="inputs"
                   [ndcDynamicOutputs]="outputs"
                   ></div>`

But It's working with <ndc-dynamic>

@gund
Copy link
Owner

gund commented Aug 9, 2017

Please have a look at this issue.

Basically it won't work with the * syntax.

I'm thinking about the possibility of making * syntax to work but as of now you should not use it.

@gund
Copy link
Owner

gund commented Aug 11, 2017

Hey @bokzor!

I've figured out how to add support for this syntax.

Now you can use * syntax with this lib since v1.1.0 like so:

<ng-container *ngComponentOutlet="component;
                            ndcDynamicInputs: inputs;
                            ndcDynamicOutputs: outputs"
                            ></ng-container>

@HMubaireek
Copy link

Hi @gund,

Plaese update the documentation according to this to save time for new users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants