Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RxJS ^7.4.0 #467

Closed
martibenn opened this issue Dec 16, 2021 · 2 comments
Closed

Support RxJS ^7.4.0 #467

martibenn opened this issue Dec 16, 2021 · 2 comments
Labels

Comments

@martibenn
Copy link

martibenn commented Dec 16, 2021

Since Angular support RxJS ^7.4.0 with @angular/common@13.1.X, would it be possible to upgrade ng-dynamic-component peer dependency on @angular/common and RxJS ?

Angular RxJS version : https://unpkg.com/browse/@angular/core@13.1.1/package.json
2021-12-16-15-21-01

ng-dynamic-component RxJS &@angular/common peer dependency :

"@angular/common": "^12.0.0 || ^13.0.0",

The error when adding ng-dynamic-component@10.0.0 on a 13.1.1 Angular problem :
npm

Thanks !

@gund
Copy link
Owner

gund commented Dec 16, 2021

Hey @martibenn, thanks for the suggestion!
Yes we can add support for rxjs v7 to peer deps!
And we do not need to do any changes to angular deps as it allows any v13 version.

@gund gund closed this as completed in c6700fb Dec 17, 2021
gund pushed a commit that referenced this issue Dec 17, 2021
# [10.1.0](v10.0.0...v10.1.0) (2021-12-17)

### Bug Fixes

* **components:** re-create dynamic component when other inputs are changed ([ea127ba](ea127ba))
* **deps:** add RxJs v7 to supported peer dependencies range ([c6700fb](c6700fb)), closes [#467](#467)

### Features

* **component:** add support for component generic ([fe8bb5d](fe8bb5d))
@gund
Copy link
Owner

gund commented Dec 17, 2021

🎉 This issue has been resolved in version 10.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gund gund added the released label Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants