Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved implementation of feature flags.
TLDR : All feature flags are now available through the plugin.
Modifications
Enum
Map
).setWelcomePageEnabled(false)
from Kotlin code as it uses feature flags under the hood (see here)Map
of feature flags instead of "static" fieldsMap
of feature flags instead of "static" fieldsexample
app to show how to use flagsWhy ?
Enum
and aMap
to modify if new feature flags are added in Jitsi Meet SDK, we don't need to add attributes/fields and everythingJitsiMeetOptions
for each flag)Enum
andMap
)flagname ? : false
and set an arbitrarytrue
orfalse
default settingReviews
I tested that modification under virtual devices, both on Android and iOS. If you want to test it yourself, go on, I'd be glad to get some feedback, and even maybe improvements 😉