Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support initiating from a Buffer instance #4

Merged
merged 1 commit into from
Sep 4, 2014
Merged

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Sep 4, 2014

Usage:

var Ascii = require('ascii');

var buf = new Buffer([...]);
var asc = Ascii.fromBuffer(buf);

asc.convert(function (err, art) {
  console.log(art);
});

guo-yu added a commit that referenced this pull request Sep 4, 2014
Support initiating from a Buffer instance
@guo-yu guo-yu merged commit 8eee519 into guo-yu:master Sep 4, 2014
@guo-yu
Copy link
Owner

guo-yu commented Sep 4, 2014

Thank you

@LinusU
Copy link
Contributor Author

LinusU commented Sep 4, 2014

Thanks for pulling, do you mind bumping version to 0.0.2 and pushing to npm? Thanks!

@LinusU LinusU deleted the patch-1 branch September 4, 2014 20:59
@guo-yu
Copy link
Owner

guo-yu commented Sep 6, 2014

@LinusU
Sure

@guo-yu
Copy link
Owner

guo-yu commented Sep 10, 2014

@LinusU v0.1.0 has been shipped.

@LinusU
Copy link
Contributor Author

LinusU commented Sep 10, 2014

Nice, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants