-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ansi colors #35
Ansi colors #35
Conversation
Pull Request Test Coverage Report for Build 2263993454
💛 - Coveralls |
Thanks, @NathanBaulch for your time to contribute to this change, it was a long time due. 🎉 🍰 I was thinking if we could also add flags for this color support in CLI utility it would be really great addon! |
Good idea, I went with |
228c545
to
5deec54
Compare
Hey @NathanBaulch, I noticed while plotting the first value i.e. ┼ , it's also changing the color of y-axis for that value, is this how you expected it to be? |
It was intentional yes, but I'm not too fussed either way. I wonder what |
Hey @NathanBaulch, could you please review the changes once, then I'll merge these changes |
Looks good @guptarohit, just my comment above about the new cmd color flag errors all being the same. |
FWIW, the color names I went with are the standard SVG/CSS ones, as listed here: https://www.w3.org/TR/SVG11/types.html#ColorKeywords |
cool, it make sense to use this link instead 👍 🎉 Thanks :) |
Colors! This branch also includes my changes in #34 since colors are particularly useful for differentiating between different series in the same plot.