Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Copy-Constructors for more CustomPropertyProviders. #154

Open
2 of 5 tasks
nightm4re94 opened this issue Jul 29, 2018 · 2 comments
Open
2 of 5 tasks

Add Copy-Constructors for more CustomPropertyProviders. #154

nightm4re94 opened this issue Jul 29, 2018 · 2 comments

Comments

@nightm4re94
Copy link
Member

nightm4re94 commented Jul 29, 2018

With 50040a3, we've introduced Copy-Constructors for the abstract types CustomPropertyProvider and Property, as well as Layers, MapObjectLayers, and MapObjects.

In an effort to unify how the engine handles cloning, we should consider adding more of these Copy-constructors to the CustomPropertyProviders Map, Terrain, Tile, and maybe others as well.

  • Map
  • MapImage
  • Terrain
  • Tile
  • Tileset
@werlikth
Copy link

Hi,
Is this still and active issue and is anyone working on it?
Otherwise I and some student partners would like to look into this issue.

@nightm4re94
Copy link
Member Author

this is still open, yes. Feel free to implement it!

felixkollin added a commit to felixkollin/litiengine that referenced this issue Feb 28, 2019
Copies a MapImage, as detailed in gurkenlabs#154. Verified with tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants