Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name field in Sprite import panel #778

Closed
nightm4re94 opened this issue Jan 8, 2023 · 13 comments
Closed

Fix name field in Sprite import panel #778

nightm4re94 opened this issue Jan 8, 2023 · 13 comments

Comments

@nightm4re94
Copy link
Member

The name panel in the Sprite import panel doesn't show the current spritesheet name or set it when changed.

@iamllcoolray
Copy link
Contributor

Hey,

I am interested in resolving this issue. Would y'all be able to provide additional information and/or anything else that could help me?

@iamllcoolray
Copy link
Contributor

Hi again,

I just wanted to comment again about my interest in tackling this issue. Can y'all provide additional information and/or anything else that could help me? For example, how I can replicate the bug, what the proper functionality should look like, where in the utiLITI project should start looking in...etc.

I know how busy everyone is so please get back to me when it is most convenient for y'all.

@nightm4re94
Copy link
Member Author

Hi, I'm sorry I was not yet able to respond. Having a busy week at work and some fun private events this week. I can't promise to be able to provide further details this week unfortunately.

@nightm4re94
Copy link
Member Author

Thanks for your patience.
The problem lies in the SpritesheetImportPanel:

spriteImportName.mp4

There is a JTextField that is supposed to show the name of the selected spritesheet. It is also supposed to let you change the spritesheet name with your input.
Neither of these behaviours work.

We might even consider dropping the JTextField entirely and letting users change the cell values in the sprite name list on the left.

@iamllcoolray
Copy link
Contributor

Awesome! I'm going to look into this bug sometime next week. (My schedule just got busy)

@nightm4re94
Copy link
Member Author

nightm4re94 commented Oct 22, 2023

I suppose it's not going anywhere until then - no hurry here 🙂

@iamllcoolray
Copy link
Contributor

Thank you for being patient with me. I just finished my courses for this Fall semester and have more free time now.
(It was brutal 😂)

So, I was trying to build Gradle in IntelliJ and got this error:

Build file 'C:\litiengine\build.gradle' line: 1

An exception occurred applying plugin request [id: 'de.gurkenlabs.semverguru', version: '1.3']
    > Failed to apply plugin 'de.gurkenlabs.semverguru'.
        > No match found

What do you think I should do to fix this?

@nightm4re94
Copy link
Member Author

I believe this is #796 again. Have you made sure to compile with Java 21?

@iamllcoolray
Copy link
Contributor

So I found a solution for the bug.

utiliti-bug-fix-778.mp4

I got the Sprite name in the text field which updates the Sprite's name in the application.

iamllcoolray added a commit to iamllcoolray/litiengine that referenced this issue Feb 29, 2024
iamllcoolray added a commit to iamllcoolray/litiengine that referenced this issue Mar 11, 2024
gurkenlabs#778 where the sprite name is updated simultaneously in the list and in the text field
nightm4re94 pushed a commit that referenced this issue Mar 11, 2024
#778 where the sprite name is updated simultaneously in the list and in the text field
@iamllcoolray
Copy link
Contributor

Saw this was still issue open but was resolved should be closed. Wasn't it supposed to close after the pull request was merged? Or did I not reference it properly?

@Gamebuster19901
Copy link
Contributor

Gamebuster19901 commented Mar 16, 2024

Saw this was still issue open but was resolved should be closed. Wasn't it supposed to close after the pull request was merged? Or did I not reference it properly?

If you add the text

Fixes #778 or Resolves #778 in a commit's message, it will close the issue when that commit is merged.

You can also put it anywhere in the first post of a pull request and it will also close the issue if the pull request is merged.

In the meantime though, we will have to wait for this to be closed manually by gurkenlabs.

@iamllcoolray
Copy link
Contributor

Saw this was still issue open but was resolved should be closed. Wasn't it supposed to close after the pull request was merged? Or did I not reference it properly?

If you add the text

Fixes #778 or Resolves #778 in a commit's message, it will close the issue when that commit is merged.

You can also put it anywhere in the first post of a pull request and it will also close the issue if the pull request is merged.

In the meantime though, we will have to wait for this to be closed manually by gurkenlabs.

Thank you so much. I just added Resolves #778 to the pull request.

@Gamebuster19901
Copy link
Contributor

Saw this was still issue open but was resolved should be closed. Wasn't it supposed to close after the pull request was merged? Or did I not reference it properly?

If you add the text
Fixes #778 or Resolves #778 in a commit's message, it will close the issue when that commit is merged.
You can also put it anywhere in the first post of a pull request and it will also close the issue if the pull request is merged.
In the meantime though, we will have to wait for this to be closed manually by gurkenlabs.

Thank you so much. I just added Resolves #778 to the pull request.

It won't work now because it's already been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants