Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language "german" #2

Closed
hvoss49 opened this issue Nov 12, 2022 · 6 comments
Closed

language "german" #2

hvoss49 opened this issue Nov 12, 2022 · 6 comments

Comments

@hvoss49
Copy link

hvoss49 commented Nov 12, 2022

+++ ../postnotes.sty	2022-11-12 21:47:46
@@ -1175,6 +1175,18 @@
 \__postnotes_set_babel_language:nn { francais } { french }
 \__postnotes_set_babel_language:nn { frenchb }  { french }
 \__postnotes_set_polyglossia_language:nn { french } { french }
+\__postnotes_define_language:nn { german }
+  {
+    \tl_set:Nn \pntitle     { Endnoten }
+    \tl_set:Nn \pnhdnotes   { Endnoten }
+    \tl_set:Nn \pnhdtopage  { zu~Seite }
+    \tl_set:Nn \pnhdtopages { zu~Seiten }
+  }
+\__postnotes_set_babel_language:nn { german }    { german }
+\__postnotes_set_babel_language:nn { ngerman }   { german }
+\__postnotes_set_babel_language:nn { austrian }  { german }
+\__postnotes_set_polyglossia_language:nn { german } { german }
+
 %% 
 %%
 %% End of file `postnotes.sty'.

@gusbrs
Copy link
Owner

gusbrs commented Nov 12, 2022

Hi @hvoss49 ,

thank you very much! I'll be glad to add them.

But, before I do so, let me ask you something. I took a look at babel's variants for german and, besides the ones you included, there are still germanb, ngermanb, naustrian, swissgerman, and nswissgerman. Do you see any reason not to include them as well?

@hvoss49
Copy link
Author

hvoss49 commented Nov 13, 2022

Only naustrian, swissgerman, and nswissgerman should be added. The other two are not used or at least I never saw a document with germanb or ngermanb

@gusbrs
Copy link
Owner

gusbrs commented Nov 13, 2022

The .ldfs exist, but I'm not really acquainted with babel-german's structure or history. So, I'll follow your advice. Thanks!

@hvoss49
Copy link
Author

hvoss49 commented Nov 13, 2022

gusbrs,
you are correct, but german.ldf simply loads germanb.ldf. And as long I remember (and that are some decades of years ... :-), everybody uses german. However, it doesn't hurt, if you prefer to use all babel definitions.
greetings from Germanys captitol
Herbert

@gusbrs
Copy link
Owner

gusbrs commented Nov 13, 2022

Hi Herbert,
I was taking a look at it, and indeed it seems germanb.ldf and ngermanb.ldf are the "working" files which the other variants load, and also that they once existed as package options, but this is deprecated (I presume since forever, given your memory of it). What I was trying to figure out was what would happen if these deprecated options were actually used (as we know, despite the efforts with documentation and what not, there's always some user). And it turns out that babel-german makes it behave as though the supported option were used. So, if one does \usepackage[ngermanb]{babel}, one gets \languagename ngerman. And, since postnotes uses the language hook, that's what matters. So, as far as I can tell, adding germanb and ngermanb would be harmless, but also pointless, in which case, better not. So, I'm sticking to your good advice.
Cheers!

gusbrs added a commit to gusbrs/zref-clever that referenced this issue Nov 13, 2022
gusbrs added a commit that referenced this issue Nov 13, 2022
@gusbrs
Copy link
Owner

gusbrs commented Nov 13, 2022

Hi Herbert,
I've just added support for German, according to your recommendations. Thank you very much once again!
I'll prepare a release so that you can enjoy this soon. :-)

@gusbrs gusbrs closed this as completed Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants