Authorization failing. Java driver expects char array for password. #5

Merged
merged 1 commit into from Dec 12, 2012

4 participants

@marclove

The Java driver expects the password passed to it for database authorization to be a char array. Fixed those methods which call the Java driver directly.

@guyboertje
Owner

I am happy to merge this.

Are you using jmongo in production? I ask because we are thinking of ceasing maintenance of jmongo.

Thanks for the fix; I ran into this one.
One thing you might consider in lib/mongo/db.rb...

      begin
        succeeded = @j_db.authenticate(username, password)
        if save_auth && succeeded
          @connection.add_auth(@name, username, password)
        end
      rescue => e
        succeeded = false
      end

The exception is eaten; this made it hard for me to find out the problem because it silently returns false. You might let the exception throw out instead.

Are you using jmongo in production?

I am considering retiring this library because I have switched to Moped (from the Mongoid guys.) Have you looked at Moped?

Collaborator

@seanpd I'm using Moped in production as well. @guyboertje had asked if I wanted to take over maintenance of this library, but since choosing Moped that's not really feasible. I vote for lib-retirement. Thanks @guyboertje for the work you put into this.

@marclove

I'm actually working with @jacaetevha on the same project. But now we're considering whether to use other jruby-compatible drivers since you're thinking of ceasing maintenance.

@guyboertje guyboertje merged commit 0dcb979 into guyboertje:master Dec 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment