Draggable user marker #29
Conversation
|
Is this relevant? Should I resolve the conflicts or close it? |
|
Hi @idoco - I don't know how I missed this PR, but noticed it just now - sorry! So, I'm closing the PR for now , but let me know if you have different thoughts regarding this! |
|
Hi Guy, this PR doesn’t make the marker follow the user.
The idea was to let the user adjust the marker location by dragging it.
This was especially important when the browser location service put my
marker in the wrong place and I had to move it to see which events are
within my 1km range.
Anyway I’m not sure it is relevant by now
…On Sat, 7 Nov 2020 at 8:31 Guy Tepper ***@***.***> wrote:
Hi @idoco <https://github.com/idoco> - I don't know how I missed this PR
and noticed it just now - I'm sorry!
We do need a static marker on the initial user position. Making it follow
the user center won't be a good UX in my opinion (look at any major map
service, where the marker stays in it's initial position).
So, I'm closing the PR for now , but let me know if you have different
thoughts regarding this!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMCIN3QY6SJGGLETVNZOZ3SOTSSLANCNFSM4SEN4NYA>
.
|
|
I understand. |
|
IMHO dragging the marker is much more flexible and easier than typing in
your address (about 20 clicks less than typing the address)
…On Sat, 7 Nov 2020 at 9:52 Guy Tepper ***@***.***> wrote:
I understand.
Now that you can change the address manually, I guess it's not relevant
anymore.
Sorry again for missing this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMCIN742NDF7BLYVGZC3LLSOT4FFANCNFSM4SEN4NYA>
.
|
|
What's the use case for this? If a desktop visitor tries to get their GPS position, isn't it way off anyway? |
|
I don’t have some hard data about this, but for desktop on WiFi the
accuracy seems to be within the same city.
For me in Tel Aviv it was just a few blocks away.
…On Sat, 7 Nov 2020 at 10:28 Guy Tepper ***@***.***> wrote:
What's the use case for this? If a desktop visitor tries to get their GPS
position, isn't it way off anyway?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMCIN45TOMMZEJDRDSEGKTSOUALHANCNFSM4SEN4NYA>
.
|
|
Okay, I understand the use case now, so I'm reopening the PR - would you like to keep work on it, updating it to reflect the changes made since? I think the only change it needs is to send the coordinates to MobX's |
|
Thanks Guy! Yes, I’ll make the changes and submit it again for review |
|
Hi @idoco, were you able to progress with this? |
The browser location service is not very accurate on desktops, so I'd love it if the positionMarker will draggable (great for small adjustments)
Once #20 will be merged this should be a small change. I used @urish context.js to get the dispatch, but couldn't test it until it is merged.
Let me know if I should proceed with this.