Feat: Toggle range of checkboxes while pressing shift key #8
Conversation
|
Woah, thanks a lot! Great work 🙂 That'd be a super useful feature. I've made some small code styling changes. Some improvements can be made to the range selection mechanism later on - I'll open an issue for that. If you'd like to take responsibility for it, let me know :) |
|
Hi! I took a look at the desired selection mechanism detailed in #9. This looks pretty simple to implement, I'd be happy to take it up. |
|
@guytepper I think I have made it consistent with the mechanism as shown done by 'checkboxes.js'. Please take a look. Thanks :) |
|
Thanks! It almost works perfectly - is it possible to make it uncheck a range of checkboxes, from the last one selected? (same as the behavior in
|
|
Hi, apologies for the delay! I took a look at the code checkboxes.js was using and implement (hopefully) the same mechanism. It'd be great if you could check it out. Thanks! |
| let startIndex; | ||
| // Where the range selection should end | ||
| let endIndex; | ||
| // Value that firstIndex initially had |
There was a problem hiding this comment.
Did you mean startIndex? Also, maybe add an explanation for the purpose of the variable :)
| } | ||
|
|
||
| const newRange = checkboxes.slice(startIndex, endIndex + 1); | ||
| previousRange.map(cb => (cb.checked = resetValue)); |
There was a problem hiding this comment.
Seems like previousRange is being declared globally on line 65.
Can you add a local declaration near the other variable declarations?
| } | ||
|
|
||
| const newRange = checkboxes.slice(startIndex, endIndex + 1); | ||
| previousRange.map(cb => (cb.checked = resetValue)); |
There was a problem hiding this comment.
Also, can you please add a comment explaining what's being done in lines 56-59?
I think a comment will make it easier to grasp :)
Hi! Great extension :)
This is a feature that I really thought would be useful, I required it myself. I have come up with an implementation in this PR, the code might be very rough - do tell me where to change it.
Thanks!