Disallow null uri as value #2461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
approved these changes
Dec 21, 2019
|
We should probably include change log or upgrade guide or both in these PRs, otherwise we will forget these removed deprecations. |
|
I already started another PR about upgrade guide.. will push it there... what is your suggested procedure that we must follow? We can merge that one and then start doing update of the CHANGELOG/UPGRADE per PR? related PR #2473 |
|
We can merge this PR now. Good thing that you added this PR to the "Breaking changes in 7" project. |
Nyholm
force-pushed
the
disallow-null-uri
branch
from
376942f
to
5033bcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if this is something we want for v7 or we should raise a deprecation notice on 7 and target this PR on 8