Support for read() operation on UInput #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to support devices with EV_LED and EV_SND
paulo-raca
force-pushed
the
uinput-read
branch
2 times, most recently
from
faf02bf
to
d599ca9
Compare
gvalkov
added a commit
that referenced
this pull request
Feb 2, 2016
Support for read() operation on UInput
|
Looks good! Thank you for contributing. Would you also consider adding a brief usage example to the tutorial tutorial page? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to support devices with EV_LED and EV_SND (Maybe others?)
This is related to the issue #45 I opened a few days ago.
Please notice that the implementation of
uinput.read()is the same asdevice.read().I was a bit unconfortable with this until I notices that
device.set_led()uses_uinput.write.I believe that's OK, since both classes are perfectly symetric to each other