Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pycbc_pygrb_page_tables #4711

Closed
1 of 2 tasks
pannarale opened this issue Apr 23, 2024 · 2 comments
Closed
1 of 2 tasks

pycbc_pygrb_page_tables #4711

pannarale opened this issue Apr 23, 2024 · 2 comments
Labels
PyGRB PyGRB development

Comments

@pannarale
Copy link
Contributor

pannarale commented Apr 23, 2024

  • The vetoed injections category is now ambiguous. It used to contain vetoed injections by looking for cases with reweighted SNR = 0, but now the cut by reweighted SNR threshold happens here (and similarly in other post-processing scripts) and not in pycbc_multi_inspiral. At the same time, vetoes are not in yet, so we are simply counting injections cut away by the reweighted SNR threshold.
  • We also need to decide how/where to store exclusion distances. At the moment they are calculated and not written to file. It is straightforward to create a nice looking table for the results webpage, but we often use these numbers also in population-like studies so we need to make them easily accessible. A json file perhaps?
@pannarale
Copy link
Contributor Author

#4756 takes care of the second item.

@sebastiangomezlopez sebastiangomezlopez added the PyGRB PyGRB development label Jun 19, 2024
@pannarale
Copy link
Contributor Author

Copying the first item into #4702 where work related to vetoes is being tracked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyGRB PyGRB development
Projects
Status: Done
Development

No branches or pull requests

2 participants