Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce default false alarm rate threshold to 1e-10 Hz #126

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Reduce default false alarm rate threshold to 1e-10 Hz #126

merged 1 commit into from
Sep 17, 2018

Conversation

alurban
Copy link
Member

@alurban alurban commented Sep 17, 2018

Note, users wanting to use a different threshold can still specify that using the command line option --far-threshold.

This fixes #125.

@alurban alurban self-assigned this Sep 17, 2018
@coveralls
Copy link

coveralls commented Sep 17, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 292

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.454%
Totals Coverage Status
Change from base Build 284: 0.0%
Covered Lines: 428
Relevant Lines: 1058
💛 - Coveralls

@alurban
Copy link
Member Author

alurban commented Sep 17, 2018

The Travis CI build failure reported here is in a unit test for sngl_burst, which this PR doesn't touch. Because the PR is so minimal I'm going to go ahead and merge it.

@alurban alurban merged commit 41c814e into gwdetchar:master Sep 17, 2018
@alurban alurban deleted the update-far branch September 17, 2018 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alurban alurban

Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce the false alarm rate threshold in omega scans
2 participants
@alurban @coveralls