-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow scattering code to trigger omega scans #291
Conversation
Thanks a lot @alurban . This looks pretty good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One actual change, but more generally, can (and should) this block be moved into a function, to make it more modular, and unit-testtable.
@duncanmmacleod, that's probably a good idea, since there are now three tools ( |
…ule, gwdetchar.omega.batch
2d46d29
to
24023fe
Compare
@duncanmmacleod, at the risk of scope creep, I've refactored the heavy-lifting parts of Once it's released, we will also be able to use this to clean up similar functionality in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a great change, just one small thing to address.
gwdetchar/io/tests/test_html.py
Outdated
times = [1126259462] | ||
channel = 'X1:STRAIN' | ||
page = html.scaffold_omega_scans(times, channel) | ||
print(page) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @duncanmmacleod, I've removed it, this was left over from when I was writing the unit test and hadn't woken up enough yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This PR adds an option
--omega-scans
, whose argument is an integer, togwdetchar-scattering
. When--omega-scans N
is nonzero, a random sample ofN
triggers that fall within active scattering segments is chosen to omega scan, with jobs launched in batch mode and displayed on the scattering page.This PR also refactors the heavy lifting in
gwdetchar-omega-batch
into a new submodule,gwdetchar.omega.batch
, including unit tests.Test output is available here (requires
LIGO.ORG
credentials).This fixes #287.
cc @duncanmmacleod, @siddharth101