Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datafind protection for running scripts on laptops #300

Merged
merged 2 commits into from
Apr 14, 2019

Conversation

alurban
Copy link
Member

@alurban alurban commented Apr 11, 2019

This PR adds a JSON exception to the logic of gwdetchar.io.datafind.get_data, which is needed to be able to run gwdetchar scripts on a laptop.

cc @duncanmmacleod

@alurban alurban added this to the 0.5.0 milestone Apr 11, 2019
@alurban alurban self-assigned this Apr 11, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 94.987% when pulling ee7f058 on alurban:fix-datafind into fd8de27 on gwdetchar:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 94.987% when pulling ee7f058 on alurban:fix-datafind into fd8de27 on gwdetchar:master.

@coveralls
Copy link

coveralls commented Apr 11, 2019

Coverage Status

Coverage increased (+0.01%) to 95.51% when pulling 11352d3 on alurban:fix-datafind into fd8de27 on gwdetchar:master.

@codecov-io
Copy link

codecov-io commented Apr 12, 2019

Codecov Report

Merging #300 into master will increase coverage by 0.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
+ Coverage   95.53%   95.54%   +0.01%     
==========================================
  Files          21       21              
  Lines        1522     1526       +4     
==========================================
+ Hits         1454     1458       +4     
  Misses         68       68
Flag Coverage Δ
#Linux 95.54% <80%> (+0.01%) ⬆️
#python27 95.22% <80%> (+0.01%) ⬆️
#python35 94.69% <40%> (-0.12%) ⬇️
#python36 94.82% <40%> (-0.12%) ⬇️
#python37 94.76% <40%> (-0.12%) ⬇️
Impacted Files Coverage Δ
gwdetchar/io/datafind.py 96.43% <80%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aed2d4...9d90d85. Read the comment docs.

@alurban alurban merged commit 1dbe068 into gwdetchar:master Apr 14, 2019
@alurban alurban deleted the fix-datafind branch April 14, 2019 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants