Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak use plot legend and significance-drop plot title #123

Merged
merged 3 commits into from
Apr 22, 2019

Conversation

alurban
Copy link
Member

@alurban alurban commented Apr 19, 2019

This PR tweaks the legend text in auxiliary use plots, and the title position in significance drop plots. Example output is available here (requires LIGO.ORG credentials).

This addresses a request by Sheila Dwyer in ligo-summary-pages.

cc @jrsmith02, @duncanmmacleod

@alurban alurban added this to the 0.4.0 milestone Apr 19, 2019
@codecov-io
Copy link

codecov-io commented Apr 19, 2019

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   53.81%   53.81%           
=======================================
  Files           7        7           
  Lines         788      788           
=======================================
  Hits          424      424           
  Misses        364      364
Flag Coverage Δ
#Linux 53.81% <100%> (ø) ⬆️
#python27 53.68% <100%> (ø) ⬆️
#python35 53.17% <100%> (ø) ⬆️
#python36 53.17% <100%> (ø) ⬆️
#python37 53.17% <100%> (ø) ⬆️
Impacted Files Coverage Δ
hveto/plot.py 54.05% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2bf26d...918aac8. Read the comment docs.

@jrsmith02
Copy link
Contributor

Looks good, if you're ok with checks not passed then I can merge.

@alurban
Copy link
Member Author

alurban commented Apr 21, 2019

Thanks for taking a look @jrsmith02. I'm not quite done with this one yet because the formatting of titles on significance-drop plots is still a bit wonky (in particular, the title and subtitle overlap with each other). I'll leave you a message and resolve WIP status once I've got that straightened out.

@alurban alurban changed the title WIP: Tweak use plot legend and significance-drop plot title position Tweak use plot legend and significance-drop plot title position Apr 21, 2019
@alurban alurban changed the title Tweak use plot legend and significance-drop plot title position Tweak use plot legend and significance-drop plot title Apr 21, 2019
@alurban
Copy link
Member Author

alurban commented Apr 21, 2019

@jrsmith02, this is now ready for your eyeballs, feel free to merge if you're happy with the changes. I've merged significance plot title and subtitle into one object (a tittle), changed the figure size (of significance drop plots) to 20 x 5, and used bbox_inches='tight' for a tight layout, in addition to the legend label changes that Sheila suggested.

@jrsmith02
Copy link
Contributor

Both plot updates look good to me.

@jrsmith02 jrsmith02 merged commit 2e45ab8 into gwdetchar:master Apr 22, 2019
@alurban alurban deleted the update-plots branch April 22, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants