Support python-3.8 and drop python-3.5 #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, this PR is needed before #141 can be merged |
|
LGTM, should I care about the travis CI build fail? |
|
Thanks @jrsmith02, yes you should definitely care, this PR is meant to address a CI failure specifically so that #141 can eventually be merged. I'll mark it a draft for the time being |
|
CI tests are now passing with Conda builds, and after rearranging a few matplotlib backend-dependent import statements, I've verified that the primary hveto scripts still works (cf. the production and test output pages). Thus, @jrsmith02 this PR is now ready to go in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for python-3.8 and drops support for python-3.5, including:
flake8linter complaints related to Conda buildsgwpy.testing.compatmoduleThis fixes #140 and fixes #133.
cc @duncanmmacleod, @jrsmith02