Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit support and build tests for Python 3.9 #147

Merged
merged 5 commits into from
Dec 10, 2020

Conversation

alurban
Copy link
Member

@alurban alurban commented Dec 3, 2020

This PR adds explicit support and build tests for python-3.9. This is needed to get out a new minor release, which will allow us to distribute hveto to Conda platforms running the new version of python, see conda-forge/hveto-feedstock#17.

@alurban alurban added this to the 1.1.0 milestone Dec 3, 2020
@alurban alurban self-assigned this Dec 3, 2020
@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #147 (e449926) into master (ac66e0a) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   36.27%   36.51%   +0.24%     
==========================================
  Files          13       13              
  Lines        1533     1534       +1     
==========================================
+ Hits          556      560       +4     
+ Misses        977      974       -3     
Flag Coverage Δ
Linux 36.51% <100.00%> (+0.24%) ⬆️
python36 36.30% <100.00%> (+0.24%) ⬆️
python37 36.30% <100.00%> (+0.24%) ⬆️
python38 36.53% <100.00%> (+0.24%) ⬆️
python39 36.53% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hveto/__init__.py 100.00% <ø> (ø)
hveto/__main__.py 11.40% <ø> (+0.22%) ⬆️
hveto/cli/cache_events.py 16.99% <ø> (+0.49%) ⬆️
hveto/cli/trace.py 43.48% <ø> (+2.17%) ⬆️
hveto/config.py 32.56% <ø> (ø)
hveto/core.py 26.25% <ø> (ø)
hveto/html.py 56.41% <ø> (ø)
hveto/plot.py 53.67% <ø> (ø)
hveto/segments.py 92.68% <ø> (ø)
hveto/triggers.py 66.18% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac66e0a...e449926. Read the comment docs.

@jrsmith02
Copy link
Contributor

My apologies for the delay in responding. Thank you so much Alex for adding explicit Python 3.9 support to hveto. LGTM.

@alurban
Copy link
Member Author

alurban commented Dec 9, 2020

No worries, thanks for taking a look @jrsmith02! I'll put out a release later today.

@alurban alurban merged commit 2852e8d into gwdetchar:master Dec 10, 2020
@alurban alurban deleted the python3.9 branch December 10, 2020 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants