Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freshen #6

Merged
merged 8 commits into from
Dec 11, 2019
Merged

Freshen #6

merged 8 commits into from
Dec 11, 2019

Conversation

Jake-Shadle
Copy link
Contributor

  • Nukes Travis and replaces it GH Actions. There is a publish job that now that can publish for you if you want, you just need to tag a release, and set the CRATES_IO_TOKEN secret in your Github settings to your crates.io token. Or just delete it if you want. 😉
  • Updated dependencies to latest
  • Renamed Encoding to Codec
  • Renamed enabled_encoding to is_codec_enabled
  • Removed the EncodingExt variant as smush can't really do anything with it other than error
  • Made Codec (Encoding) Copy so that the API is more ergonomic
  • Just imported all the variants of Codec and Quality inside lib.rs so that there was vastly less typing.

If a user wants to support other codecs
they can either add it to this library, or just
discriminate in their own code between
codecs supplied by smush, and the other ones.

This also makes the Quality and Encoding
types Clone, which cleans up the API usage a bit
for example in the example program.
Copy link
Owner

@gwihlidal gwihlidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gwihlidal gwihlidal merged commit 6a63777 into gwihlidal:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants