Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic change columns, item will overlap #12

Closed
UTing1119 opened this issue Aug 8, 2023 · 12 comments · Fixed by #14
Closed

dynamic change columns, item will overlap #12

UTing1119 opened this issue Aug 8, 2023 · 12 comments · Fixed by #14
Assignees
Labels
bug Something isn't working

Comments

@UTing1119
Copy link
Collaborator

Expected Behavior

dynamic change columns and it should calculate new item's position correctly.

Current Behavior

item will overlap

Steps to Reproduce

  1. dynamic change columns
  2. the item which is overflow will change to position 1 and overlap the first item

wcvb9-ws07f

I will try to fix it, plz let me know if the overflow item is static, how would you want it to behave

@gwinnem
Copy link
Owner

gwinnem commented Aug 8, 2023 via email

@gwinnem gwinnem self-assigned this Sep 7, 2023
@gwinnem gwinnem added the bug Something isn't working label Sep 7, 2023
@gwinnem
Copy link
Owner

gwinnem commented Sep 7, 2023

Hi, @UTing1119 did you manage to make a fix for this ?

@UTing1119
Copy link
Collaborator Author

UTing1119 commented Sep 8, 2023

yes, I was tryna find the reason why the resize event will be triggered when col number is set by user.(edit: yes it needs to be resized, but I'm trying to fix the calculate function)

do you have any plans to refactor?

@gwinnem
Copy link
Owner

gwinnem commented Sep 8, 2023

Hi @UTing1119
I am doing some work on the component right now, and will look into this issue to. Just wanted to check up on your progress on this issue.

@gwinnem
Copy link
Owner

gwinnem commented Sep 19, 2023

@UTing1119 may I ask what you are using the component for ?

Btw I just released version 1.2.2

Regards

Geirr

@UTing1119
Copy link
Collaborator Author

@gwinnem if you're referring to dragging items, that's because I'm tryna set up a template item that will be added to the GridLayout correctly.
and maybe provide slots for users to customize its appearance.

but unfortunately I have no time to fix it or refactor it.
if any idea, plz let me know

@UTing1119
Copy link
Collaborator Author

still not work in version 1.2.2/1.2.4/1.2.5

@UTing1119 UTing1119 reopened this Dec 29, 2023
@gwinnem
Copy link
Owner

gwinnem commented Dec 30, 2023

@UTing1119
I'll try to fix this asap.
Currently working on the Resize enhancement issue
But will pause this and start working on this issue.

@gwinnem gwinnem added this to the Release 1.2.7 milestone Dec 30, 2023
@gwinnem
Copy link
Owner

gwinnem commented Jan 2, 2024

Hi @UTing1119
If im correct, it is alway the top left GridItem which have this issue ?

@gwinnem gwinnem added the question Further information is requested label Jan 2, 2024
@UTing1119
Copy link
Collaborator Author

I think it's more like the item overflows right side of the layout.

I guess it's because in src/core/helpers/responsiveUtils.ts, both moveToCorrectPlace and correctBounds function only consider about whether to collide with static items or not.

@gwinnem gwinnem removed the question Further information is requested label Jan 2, 2024
@gwinnem
Copy link
Owner

gwinnem commented Jan 2, 2024

I think it's more like the item overflows right side of the layout.

I guess it's because in src/core/helpers/responsiveUtils.ts, both moveToCorrectPlace and correctBounds function only consider about whether to collide with static items or not.

It is strange the behavior, but with multiple statics the result is a lot of overflows when dynamically changes the max col value.

I am looking into it now and will release a new version asap.

@gwinnem gwinnem removed this from the Release 1.2.7 milestone Jan 10, 2024
gwinnem added a commit that referenced this issue Jan 25, 2024
@gwinnem
Copy link
Owner

gwinnem commented Feb 2, 2024

Should be fixed in 1.2.9

@gwinnem gwinnem closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants