-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/bun cli to js api #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules and modified lines of code than 97% of the historic high-risk change sets. The risk is lower since it is an experienced author responsible for 99% of all commits in this repo.
View detailed results in CodeScene
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
============================================
- Coverage 97.07% 96.95% -0.12%
Complexity 42 42
============================================
Files 6 6
Lines 205 197 -8
============================================
- Hits 199 191 -8
Misses 6 6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules and modified lines of code than 97% of the historic high-risk change sets. The risk is lower since it is an experienced author responsible for 99% of all commits in this repo.
View detailed results in CodeScene
This PR refactors the bun cli to js api.
This adds another layer, since we need to pass configuration to node process but allows us to have more control on how bun builds your bundles and opens the door to adding plugin support.
After this is merged I'm planning to write a css loader plugin. This is one of the bigger missing features I like to grok