Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve getting time coordinates from groundwater model objects #178

Merged
merged 9 commits into from
May 15, 2023
Merged

Improve getting time coordinates from groundwater model objects #178

merged 9 commits into from
May 15, 2023

Conversation

dbrakenhoff
Copy link
Collaborator

  • Build time coordinate from flopy groundwater model object, usage: nlmod.time.ds_time_from_model(model)
  • Use new function to obtain time coordinate when reading heads/concentrations using groundwater model object.
  • Add function to get budget for specific record as DataArray

OnnoEbbens
OnnoEbbens reviewed May 15, 2023
View reviewed changes
nlmod/dims/time.py Outdated Show resolved Hide resolved
OnnoEbbens
OnnoEbbens reviewed May 15, 2023
View reviewed changes
Copy link
Collaborator

@OnnoEbbens OnnoEbbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things to fix and then it is good to go

nlmod/gwf/output.py Outdated Show resolved Hide resolved
@dbrakenhoff dbrakenhoff merged commit 0773ed1 into dev May 15, 2023
@dbrakenhoff dbrakenhoff deleted the time-coord-outputs branch May 15, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OnnoEbbens OnnoEbbens OnnoEbbens left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbrakenhoff @OnnoEbbens