Buisdrainage #276
Buisdrainage #276
Conversation
nlmod/gwf/surface_water.py
Outdated
| @@ -1024,8 +1024,10 @@ def add_season_timeseries( | |||
| package, | |||
| summer_months=(4, 5, 6, 7, 8, 9), | |||
| filename="season.ts", | |||
| seasons=("winter", "summer"), | |||
| seasons=None, | |||
There was a problem hiding this comment.
Why set seasons to None? The keyword summer_months sort of suggests winter/summer being the only possible two seasons?
There was a problem hiding this comment.
I changed this as a tuple gave a bug, seasons (time_series_namerecord) somehow needed to be a list, and it is not allowed to to add a list as an optional arggument. Therefore when seasons is None, I set it to seasons = ["winter", "summer"]. Maybe better to add two arguments, called winter_name and summer_name?
|
|
||
| # make sure crs is set of ds | ||
| if ds.rio.crs is None: | ||
| ds = ds.rio.write_crs(28992) |
There was a problem hiding this comment.
should we use the EPSG definition in nlmod for this?
There was a problem hiding this comment.
Somehow this does not give the same problems as with maps (I believe, but did not thoroughly check). It might break stuff, if we change this. If other data sources are also in 28992, they do not need to be transformed, but if we change the crs of the model Dataset to our own definition, an unwanted transformation is applied. The buisdrainage data is in WGS84, so you may be right. Let's check this in the future.
- added one docstring, fixed some typos, sort imports
|
Modifying the EPSG definition doesn't seem to affect the result, but the result does seem somewhat shifted relative to the backgroundmap, though it's difficult to be certain. That being said, the result is the same as on the NHI dataportal website, but it might be shifted there too...
|
This pull request adds support for buisdrainage from the NHI-website to nlmod. Also, it fixes some small bugs in code and documentation, for example issue #261