Add get_flow_residuals and get_flow_lower_face #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix lays parameter for structured grids
So it also works for multiple packages of the same type (for example 3 DRN-packages), by summing the budgets
OnnoEbbens
requested changes
Feb 26, 2024
| Parameters | ||
| ---------- | ||
| ds : xarray.Dataset | ||
| Xarray dataset with model data. |
There was a problem hiding this comment.
Xarray dataset with model data and the 'botm' datavar.
nlmod/gwf/output.py
Outdated
| return da | ||
|
|
||
|
|
||
| def get_flow_lower_face(ds, kstpkper=None, grb_file=None, lays=None): |
There was a problem hiding this comment.
Sluikreclame? Why not layers instead of lays?
There was a problem hiding this comment.
Omdat het integers zijn. layer duidt meer op de laag-naam.
nlmod/gwf/output.py
Outdated
| flowja = cbf.get_data(text="FLOW-JA-FACE", kstpkper=kstpkper) | ||
|
|
||
| if ds.gridtype == "vertex": | ||
| # detemine flf_index first |
| return np.ma.sum(data, axis=0) | ||
|
|
||
|
|
||
| def _get_binary_budget_record(fobj, ipos, header, column): |
|
Thanks for the review. I implemented most of the requested changes. On top of that, I renamed |
OnnoEbbens
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the title of this PR