Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEI plots and possibly others show data in Ready state when there is no active segment #358

Open
eagoetz opened this issue Jan 12, 2023 · 1 comment

Comments

@eagoetz
Copy link
Collaborator

eagoetz commented Jan 12, 2023

See for example
https://ldas-jobs.ligo-la.caltech.edu/~evan.goetz/summary/gps/1357516818-1357520418/sei/ham7/#isolated
and
https://ldas-jobs.ligo-la.caltech.edu/~evan.goetz/summary/gps/1357516818-1357520418/sei/ham7/#ready

There is no active segment for this interval in the "Ready" state:

<SummaryState('Ready',
              known=[[1357516818 ... 1357520418)]
              active=[]
              description=None)>

but nonetheless, there is a plot with data shown.

Something seems amiss here.

To reproduce this example:

python -m pdb -m gwsumm gps --verbose --ifo L1 --on-segdb-error warn --on-datafind-error warn --output-dir . 1357516818 1357520418 --config-file ${CONFIG}/defaults.ini,${CONFIG}/common/global.ini,${CONFIG}/common/sei-ham.ini,${CONFIG}/l1/l1sei-ham.ini -t SEI-HAM7
@eagoetz
Copy link
Collaborator Author

eagoetz commented Mar 8, 2023

There may be a related issue with the states for the "quiet" and "noisy" times on the network SEI pages: the "Quiet" state and "Noisy" states are simply the entire day because the known/active properties are set to be the entire day. They do not derive from the actual quiet and noisy times for H1 and L1. In some sense the "Quiet" and "Noisy" states should be meta-states, where the data shown for "Quiet" should be the H1 quiet times and L1 quiet times, which do not fully intersect. The same is true for Noisy.

eagoetz pushed a commit to eagoetz/gwsumm that referenced this issue Mar 16, 2023
…m different detectors

This fixes a problem where the "Quiet" and "Noisy" states were undefined in time, so the whole duration was used. This meant there was no distinction between the states as plotted for the summary pages.

A metastate would be defined as
```
[metastate-Quiet]
key = Quiet
name = SEI Quiet
uses = H1-quiet,L1-quiet

[state-H1-Quiet]
name = SEI Quiet
key = H1-quiet
hours = 1-5,H1

[state-L1-Quiet]
name = SEI Quiet
key = L1-quiet
hours = 2-6,L1
```

It is not super robust in that it's really only supposed to be used for combining some interval for H1 and some interval for L1. I'm not sure it's really ready to be heavily used in many situations

Addresses the comment in gwpy#358
eagoetz pushed a commit to eagoetz/gwsumm that referenced this issue Mar 16, 2023
…m different detectors

This fixes a problem where the "Quiet" and "Noisy" states were undefined in time, so the whole duration was used. This meant there was no distinction between the states as plotted for the summary pages.

A metastate would be defined as
```
[metastate-Quiet]
key = Quiet
name = SEI Quiet
uses = H1-quiet,L1-quiet

[state-H1-Quiet]
name = SEI Quiet
key = H1-quiet
hours = 1-5,H1

[state-L1-Quiet]
name = SEI Quiet
key = L1-quiet
hours = 2-6,L1
```

It is not super robust in that it's really only supposed to be used for combining some interval for H1 and some interval for L1. I'm not sure it's really ready to be heavily used in many situations

Addresses the comment in gwpy#358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant