Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use backports configparser package for python < 3.6 #248

Merged
merged 2 commits into from
Apr 12, 2019

Conversation

duncanmmacleod
Copy link
Member

This PR updates the dependencies to use the backports configparser package for python < 3.6. This allows us to simplify the imports of that module to use up-to-date ('python3') names, removing the need for six at least in this case, and removing ambiguity about which package (stdlib configparser, backports configparser, or stdlib ConfigParser) will be used at runtime.

in order to simplify imports, we should use the backport package `configparser`
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 37.235% when pulling 5b77c3f on duncanmmacleod:configparser into 20faebf on gwpy:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 37.235% when pulling 5b77c3f on duncanmmacleod:configparser into 20faebf on gwpy:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 37.235% when pulling 5b77c3f on duncanmmacleod:configparser into 20faebf on gwpy:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 37.235% when pulling 5b77c3f on duncanmmacleod:configparser into 20faebf on gwpy:master.

Copy link

@alurban alurban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @duncanmmacleod, and this takes away more lines than it adds, so you get double points!

@alurban alurban merged commit 5b88057 into gwpy:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants