Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the gwdetchar.io.html.alert utility to render bootstrap alert boxes #283

Merged
merged 2 commits into from
Jul 6, 2019

Conversation

alurban
Copy link

@alurban alurban commented Jul 6, 2019

This PR refactors and simplifies construction of bootstrap alert boxes by taking advantage of the brand-new gwdetchar.io.html.alert utility available in gwdetchar-1.0.0 (pre-release). Various PEP-8 compliance fixes are also included.

cc @duncanmmacleod

@alurban alurban added this to the 1.0.0 milestone Jul 6, 2019
@alurban alurban self-assigned this Jul 6, 2019
@codecov
Copy link

codecov bot commented Jul 6, 2019

Codecov Report

Merging #283 into master will increase coverage by 0.13%.
The diff coverage is 43.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   38.75%   38.88%   +0.13%     
==========================================
  Files          47       47              
  Lines        7415     7387      -28     
==========================================
- Hits         2873     2872       -1     
+ Misses       4542     4515      -27
Flag Coverage Δ
#Linux 38.88% <43.75%> (+0.13%) ⬆️
#python35 38.88% <43.75%> (+0.13%) ⬆️
#python36 38.88% <43.75%> (+0.13%) ⬆️
#python37 38.88% <43.75%> (+0.13%) ⬆️
Impacted Files Coverage Δ
gwsumm/tabs/core.py 31.16% <ø> (-0.32%) ⬇️
gwsumm/tabs/misc.py 44.74% <ø> (ø) ⬆️
gwsumm/tabs/data.py 10.82% <0%> (+0.06%) ⬆️
gwsumm/tabs/etg.py 15.12% <0%> (+0.26%) ⬆️
gwsumm/tabs/guardian.py 19.25% <0%> (+0.6%) ⬆️
gwsumm/html/bootstrap.py 100% <100%> (ø) ⬆️
gwsumm/tabs/fscan.py 16.41% <25%> (+1.08%) ⬆️
gwsumm/tabs/stamp.py 36.84% <50%> (+4.58%) ⬆️
gwsumm/tabs/sei.py 14.84% <66.67%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a38de90...9d75521. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 6, 2019

Codecov Report

Merging #283 into master will increase coverage by 0.13%.
The diff coverage is 43.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   38.75%   38.88%   +0.13%     
==========================================
  Files          47       47              
  Lines        7415     7387      -28     
==========================================
- Hits         2873     2872       -1     
+ Misses       4542     4515      -27
Flag Coverage Δ
#Linux 38.88% <43.75%> (+0.13%) ⬆️
#python35 38.88% <43.75%> (+0.13%) ⬆️
#python36 38.88% <43.75%> (+0.13%) ⬆️
#python37 38.88% <43.75%> (+0.13%) ⬆️
Impacted Files Coverage Δ
gwsumm/tabs/core.py 31.16% <ø> (-0.32%) ⬇️
gwsumm/tabs/misc.py 44.74% <ø> (ø) ⬆️
gwsumm/tabs/data.py 10.82% <0%> (+0.06%) ⬆️
gwsumm/tabs/etg.py 15.12% <0%> (+0.26%) ⬆️
gwsumm/tabs/guardian.py 19.25% <0%> (+0.6%) ⬆️
gwsumm/html/bootstrap.py 100% <100%> (ø) ⬆️
gwsumm/tabs/fscan.py 16.41% <25%> (+1.08%) ⬆️
gwsumm/tabs/stamp.py 36.84% <50%> (+4.58%) ⬆️
gwsumm/tabs/sei.py 14.84% <66.67%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a38de90...25e7d13. Read the comment docs.

@alurban alurban merged commit 7940366 into gwpy:master Jul 6, 2019
@alurban alurban deleted the alert-box branch July 6, 2019 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant