Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force timezone to UTC for javascript utilities #291

Merged
merged 3 commits into from
Sep 2, 2019

Conversation

alurban
Copy link

@alurban alurban commented Sep 2, 2019

This PR attempts to set links constructed with bootstrap-datepicker, particularly the Today link at the bottom of the calendar, to use UTC rather than the local timezone of the browser. This is to avoid browser-side issues for users in timezones east of London, who currently see links to a nonexistent page for at least one hour each day.

This PR also sets the calendar to begin on Sunday rather than Monday.

Example output is available here.

cc @duncanmmacleod

@alurban alurban added the html label Sep 2, 2019
@alurban alurban added this to the 1.0.0 milestone Sep 2, 2019
@alurban alurban self-assigned this Sep 2, 2019
@codecov
Copy link

codecov bot commented Sep 2, 2019

Codecov Report

Merging #291 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   38.93%   38.93%           
=======================================
  Files          47       47           
  Lines        7496     7496           
=======================================
  Hits         2918     2918           
  Misses       4578     4578
Flag Coverage Δ
#Linux 38.93% <ø> (ø) ⬆️
#python35 38.93% <ø> (ø) ⬆️
#python36 38.93% <ø> (ø) ⬆️
#python37 38.93% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99c1535...dd8908e. Read the comment docs.

@alurban alurban merged commit 9b1cdb7 into gwpy:master Sep 2, 2019
@alurban alurban deleted the utc-today branch September 2, 2019 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant