Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement acorn checks for GWSumm JavaScript #297

Merged
merged 4 commits into from
Oct 7, 2019

Conversation

alurban
Copy link

@alurban alurban commented Oct 7, 2019

This PR implements an additional build-and-test phase for JavaScript elements using acorn, and for CSS elements using stylelint and standard SASS guidelines. The gwsumm.scss source file is corrected for a number of linting complaints.

This also explicitly requires flake8 and pytest-cov from the setup.py script.

cc @duncanmmacleod

@alurban alurban added this to the 1.0.0 milestone Oct 7, 2019
@alurban alurban self-assigned this Oct 7, 2019
@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #297 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #297   +/-   ##
=======================================
  Coverage   38.89%   38.89%           
=======================================
  Files          47       47           
  Lines        7529     7529           
=======================================
  Hits         2928     2928           
  Misses       4601     4601
Flag Coverage Δ
#Linux 38.89% <ø> (ø) ⬆️
#python35 38.86% <ø> (ø) ⬆️
#python36 38.89% <ø> (ø) ⬆️
#python37 38.89% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 054f603...0fa9227. Read the comment docs.

@alurban alurban merged commit a6179d7 into gwpy:master Oct 7, 2019
@alurban alurban deleted the npm-checks branch October 7, 2019 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant