Implement acorn checks for GWSumm JavaScript #297
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an additional build-and-test phase for JavaScript elements using
acorn
, and for CSS elements usingstylelint
and standard SASS guidelines. Thegwsumm.scss
source file is corrected for a number of linting complaints.This also explicitly requires
flake8
andpytest-cov
from thesetup.py
script.cc @duncanmmacleod