Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take advantage of event listeners in gwbootstrap #300

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

alurban
Copy link

@alurban alurban commented Oct 16, 2019

This PR takes advantage of a couple new event listeners added to gwbootstrap for button click actions, including for table-to-CSV conversion and the return-to-top button.

See also gwdetchar/gwbootstrap#9.

cc @duncanmmacleod

@alurban alurban added this to the 1.0.0 milestone Oct 16, 2019
@alurban alurban self-assigned this Oct 16, 2019
@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #300 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   39.09%   39.09%           
=======================================
  Files          47       47           
  Lines        7562     7562           
=======================================
  Hits         2956     2956           
  Misses       4606     4606
Flag Coverage Δ
#Linux 39.09% <100%> (ø) ⬆️
#python35 39.06% <100%> (ø) ⬆️
#python36 39.09% <100%> (-60.91%) ⬇️
#python37 39.09% <100%> (ø) ⬆️
Impacted Files Coverage Δ
gwsumm/tabs/gracedb.py 13.5% <ø> (ø) ⬆️
gwsumm/tabs/guardian.py 19.05% <ø> (ø) ⬆️
gwsumm/tabs/sei.py 15.06% <ø> (ø) ⬆️
gwsumm/html/bootstrap.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4277018...b7aea95. Read the comment docs.

@alurban alurban merged commit 0b1c9f2 into gwpy:master Oct 16, 2019
@alurban alurban deleted the event-listeners branch October 16, 2019 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant