Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch TypeErrors that arise writing StateVector objects #326

Merged
merged 1 commit into from
Jan 17, 2021

Conversation

alurban
Copy link

@alurban alurban commented Jan 17, 2021

This PR applies a band-aid to an error I'm seeing in production, in which gwsumm.archive._write_data fails on writing StateVector objects because of byte representation.

cc @duncanmmacleod

@alurban alurban self-assigned this Jan 17, 2021
@codecov
Copy link

codecov bot commented Jan 17, 2021

Codecov Report

Merging #326 (9eeaba5) into master (8a6790e) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #326   +/-   ##
=======================================
  Coverage   50.47%   50.47%           
=======================================
  Files          60       60           
  Lines        8636     8636           
=======================================
  Hits         4359     4359           
  Misses       4277     4277           
Flag Coverage Δ
Linux 50.47% <0.00%> (ø)
python36 49.67% <0.00%> (ø)
python37 49.67% <0.00%> (ø)
python38 50.47% <0.00%> (ø)
python39 50.47% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gwsumm/archive.py 76.97% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a6790e...9eeaba5. Read the comment docs.

@alurban alurban merged commit 2050fca into gwpy:master Jan 17, 2021
@alurban alurban deleted the statevector-archive branch January 17, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant