Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GPS intervals output a gps directory #341

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Conversation

eagoetz
Copy link
Collaborator

@eagoetz eagoetz commented Jul 22, 2022

GPS intervals were output inconsistently with day/week/month mode. Now they will output to gps/start-end/ instead of start-end/ to be consistent between the modes.

Closes #336

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #341 (1af35fd) into master (06e8250) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #341   +/-   ##
=======================================
  Coverage   50.31%   50.31%           
=======================================
  Files          60       60           
  Lines        8658     8658           
=======================================
  Hits         4356     4356           
  Misses       4302     4302           
Flag Coverage Δ
Linux 50.31% <ø> (ø)
macOS 50.31% <ø> (ø)
python3.10 50.31% <ø> (ø)
python3.7 49.51% <ø> (ø)
python3.8 50.31% <ø> (ø)
python3.9 50.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

@eagoetz eagoetz self-assigned this Aug 10, 2022
@duncanmmacleod
Copy link
Member

@eagoetz, what problem is this change designed to solve? I think this creates an unnecessary level of hierarchy that is non-intuitive to the reader.

@eagoetz
Copy link
Collaborator Author

eagoetz commented Oct 3, 2022

@eagoetz, what problem is this change designed to solve? I think this creates an unnecessary level of hierarchy that is non-intuitive to the reader.

The problem is that the gps mode does not follow the <mode>/<epoch> structure that day, week, and month modes follow. This PR solves this inconsistency.

I'm not sure I understand why this is non-intuitive. Can you clarify?

@duncanmmacleod
Copy link
Member

@eagoetz, what problem is this change designed to solve? I think this creates an unnecessary level of hierarchy that is non-intuitive to the reader.

The problem is that the gps mode does not follow the <mode>/<epoch> structure that day, week, and month modes follow. This PR solves this inconsistency.

I'm not sure I understand why this is non-intuitive. Can you clarify?

I'm pretty sure I'm overthinking it. Most of the important GPS pages I generated had symlinks so memorable names ('O3') so the underlying gps/1234567890-1234567890 was never seen by the user.

Anyways, carry on.

@eagoetz eagoetz merged commit 4ef8a13 into gwpy:master Oct 12, 2022
@eagoetz eagoetz deleted the gps-dir branch October 12, 2022 14:58
@eagoetz eagoetz added this to the 2.1.1 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gwsumm gps mode should make directories inside of a 'gps' folder
2 participants