Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code format and spelling errors in tutorial #269

Merged
merged 2 commits into from
Feb 7, 2018

Conversation

mincong-h
Copy link
Contributor

@mincong-h mincong-h commented Feb 6, 2018

Hi GWT team,

Here's a trivial fix for code formatting and spelling errors found in GWT Tutorials.


This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@mincong-h
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Feb 6, 2018
Copy link
Member

@jnehlmeier jnehlmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the comment, nice work!


class StockData extends JavaScriptObject { // <span style="color:black;">**(1)**</span>
class StockData extends JavaScriptObject { // <span style="color:black;">**(1)**</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind changing // <span style="color:black;">**(1)**</span> to // (1) and making sure these comments start on the same column (there are a few more below)?

Currently it renders bad as well: http://www.gwtproject.org/doc/latest/tutorial/JSON.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't change them because I didn't know which formatting to choose. You proposal is a good idea. Just fixed it up.

@tbroyer
Copy link
Member

tbroyer commented Feb 7, 2018

Thank you!

@tbroyer tbroyer merged commit daec1b7 into gwtproject:master Feb 7, 2018
@mincong-h mincong-h deleted the tutorial branch February 7, 2018 09:09
@mincong-h
Copy link
Contributor Author

My pleasure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants