-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix code format and spelling errors in tutorial #269
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside the comment, nice work!
|
||
class StockData extends JavaScriptObject { // <span style="color:black;">**(1)**</span> | ||
class StockData extends JavaScriptObject { // <span style="color:black;">**(1)**</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind changing // <span style="color:black;">**(1)**</span>
to // (1)
and making sure these comments start on the same column (there are a few more below)?
Currently it renders bad as well: http://www.gwtproject.org/doc/latest/tutorial/JSON.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't change them because I didn't know which formatting to choose. You proposal is a good idea. Just fixed it up.
Thank you! |
My pleasure :) |
Hi GWT team,
Here's a trivial fix for code formatting and spelling errors found in GWT Tutorials.
This change is