Upgrade Jetty to 9.x

[dankurka]

Originally reported on Google Code with ID 8747

Jetty 8.1 is outdated, please upgrade to the Jetty release 9.x.

Found in GWT Release: trunk

Detailed description (please be as specific as possible):

If project using GWT depends on Jetty 9.1 then it collides with the Jetty 8.1 packaged
in gwt-dev.jar.

Workaround if you have one:

The only known workaround to make it work is to strip Jetty packages from gwt-dev.jar
and use
more recent Jetty 9.1 installation during fetching from Maven repository.

Unfortunately this works only unless gwt-codeserver.jar is used. Trying to set up SuperDevMode

and start codeserver with stripped gwt-dev.jar refuses to work:

Compile completed in 21470 ms
java.lang.NoClassDefFoundError: org/eclipse/jetty/server/nio/SelectChannelConnector
    at com.google.gwt.dev.codeserver.WebServer.start(WebServer.java:108)
    at com.google.gwt.dev.codeserver.CodeServer.start(CodeServer.java:101)
    at com.google.gwt.dev.codeserver.CodeServer.main(CodeServer.java:71)
    at com.google.gwt.dev.codeserver.CodeServer.main(CodeServer.java:49)

Reported by David.Ostrovsky on 2014-06-03 10:43:17

[dankurka]

Htmlunit is still using Jetty 8.1. That's why I upgraded to that version.

Reported by goktug@google.com on 2014-06-03 21:01:57

[dankurka]

Can we do this before IO?

Reported by branflake2267 on 2014-06-03 21:02:22

[dankurka]

OK, i see. It seems like monolithic jetty-websocket underwent major redesign in Jetty
9.X
and was splited into different maven modules [1].

OTOH we don't use HtmlUnit at all. As it was pointed out in these changes [2], [3]
we could just
strip Jetty entirely from gwt-dev.jar and upgrade it to 9.1 and everything just work.

With one exception CodeServer.

I wonder if another approach would be not to package Jetty (and HtmlUnit ?) in gwt-dev.jar
at all,
and instead add Maven dependency to gwt-dev-pom.xml like this is already the case for
org.json package?

In addition include gwt-codeserver-jetty-9.X.jar in distribution that is compatible
with latest and greatest
Jetty version.

That would simplify life for projects that want to include newest Jetty version, and
strip the outdated
Jetty version currently packaged in gwt-dev.jar anyway, and would (hopefully) fix broken
SuperDevMode.

[1] https://webtide.com/jetty-9-updated-websocket-api
[2] https://gerrit-review.googlesource.com/51722
[3] https://gerrit-review.googlesource.com/53510

Reported by David.Ostrovsky on 2014-06-04 09:52:53

[dankurka]

We're back to dependency-hell that could be solved with modularization.

The current uses of Jetty in GWT are: DevMode's default ServletContainerLauncher, SuperDevMode
and GWT-JUnit.

If we could move DevMode out of gwt-dev (e.g. gwt-devmode) then we could remove Jetty
from gwt-dev (add dependencies from gwt-user, codeserver and gwt-devmode to Jetty for
Maven, and packaging it in the GWT SDK, like we package validation-api).

I think we can do that by I/O.
It won't solve Gerrit issues though, just move the problem: they just wouldn't need
to strip Jetty from gwt-dev as it would no longer be bundled, but still have to bring
it in the classpath when launching CodeServer (they don't have GWTTestCase), which
currently requires a small refactoring of the build scripts, and pulling Jetty 8 from
Central only for CodeServer.

In the future, we could similarly extract GWT-JUnit into its own set of JARs: one with
the API to compile your code against, and one with the "runtime"; only the runtime
needs Jetty.
We could technically have GWT-JUnit depend on the same version of Jetty that's used
by HtmlUnit, and CodeServer depend on another version, but it could become a nightmare
for GWT users to manage their classpaths!

@David: as I said on the Gerrit forum, ideally you'd manage 3 classpaths: build classpath,
server-side runtime classpath and GWT classpath (used by CodeServer and GWT compiler).
build and server-side runtime classpaths can use Jetty 9.x, and GWT classpath (CodeServer
only, and/or GWT-JUnit for those who have GWTTestCase) can include Jetty 8.x.

Reported by t.broyer on 2014-06-04 10:25:34

[dankurka]

Sorry I shouldn't have mentioned a can you do it by, kicking my self for saying that
after I posted. 

I'm looking at using one of the runners to use with the enhancement I'm working on
and this particular issue might play apart. I'll bring it up later when I cross that
bridge.

Thanks for more details, that helps with what I'm working on at the moment. 

Reported by branflake2267 on 2014-06-04 14:29:59

[dankurka]

I've done most of the work (that I experienced as necessary) to upgrade the in-built
jetty to version 9 (this is for the "classic" dev mode launcher) as it was necessary
to bootstrap my spring-based server code via annotations. I don't know how "correct"
it is. Particularly, I didn't update the SSL configuration logic to work I simply commented
it out or deleted it, since I don't use it.

This may not be the "whole problem" but as far as running jetty 9 in dev mode it met
my needs.

Reported by heptet2014 on 2014-06-10 03:35:36

[dankurka]

Change under review:

https://gwt-review.googlesource.com/7856

Reported by David.Ostrovsky on 2014-06-15 06:32:53

[dankurka]

I filed issue for HtmlUnit project to upgrade to Jetty 9: [1].

https://sourceforge.net/p/htmlunit/bugs/1656/

Reported by David.Ostrovsky on 2014-12-20 12:33:51

[dankurka]

Patch that migrates htmlunit to Jetty 9.2.6 was merged yesterday. htmlunit doesn't depend
on Jetty 8 anymore. htmlunit 2.16 snapshot artifacts can be doenloaded here: [1].

Can we move forward with this patch: [2]?

[1] https://ci.canoo.com/teamcity/viewLog.html?buildId=137468&buildTypeId=Htmlunit_CheckInBuild&tab=artifacts

[2] https://gwt-review.googlesource.com/#/c/7857/

Reported by David.Ostrovsky on 2015-01-14 20:18:46

[dankurka]

I have no objections to upgrading to Jetty 9. However, I'll point out that another approach
would be to launch Super Dev Mode separately and use -launcherDir to write the files
to your Jetty 9 war dir, so that they can have two different classpaths.

Here's a post about some work Brandon Donnelson is doing in GPE that allows support
for arbitrary servlet engines, not just Jetty:
https://plus.google.com/111739836936169749229/posts/1BKe5jsaUCR

Reported by bslesinsky on 2015-01-18 04:26:22

[dankurka]

> Htmlunit is still using Jetty 8.1. That's why I upgraded to that version.

I fixed that: HtmlUnit 2.16 uses Jetty 9.2.10.

> I have no objections to upgrading to Jetty 9.

Can we consider to fix this issue and merge [1] before GWT 2.8 final release?

[1] https://gwt-review.googlesource.com/7857

Reported by David.Ostrovsky on 2015-05-17 11:58:08

[dankurka]

I think it would be a good thing; let's tentatively add it to the milestone.

Reported by t.broyer on 2015-05-17 16:35:52

• Labels added: Milestone-2_8

[dankurka]

> let's tentatively add it to the milestone 2.8.

Thanks.

Can someone change the status to ReviewPending?

Reported by David.Ostrovsky on 2015-05-17 18:19:56

[dankurka]

Reported by t.broyer on 2015-05-19 13:38:54

• Status changed: ReviewPending

[pgtaboada]

What is the status of this issue?

[wisebaldone]

Is there anyway that this can be pushed up in priority

[davido]

It's done and is ready to be merged: [1].

• [1] https://gwt-review.googlesource.com/7857

[wisebaldone]

@davido you still need to put the jetty 9 libs in the tools repo from talking to devs on ##gwt so that the automated tests can work.

[tbroyer]

I think you can make a pull request on the tools repo

[davido]

I think you can make a pull request on the tools repo

gwtproject/tools#3