Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error reporting for System.getProperty magic method nodes #9812

Merged
merged 10 commits into from
Apr 11, 2023

Conversation

niloc132
Copy link
Contributor

An earlier iteration appeared to add getProperty to GWT.java instead of using System. In that implementation, the "answers" for rebind seemed to be reused to hold default expressions, but that also changed before it was submitted to GWT.

Fixes #9806

@niloc132 niloc132 added this to the 2.11 milestone Mar 26, 2023
@jnehlmeier
Copy link
Member

Looks good, but please squash all commits before merging.

@niloc132
Copy link
Contributor Author

Looks good, but please squash all commits before merging.

Thanks, standard process is as with gerrit, we always do squash-and-merge, with a single descriptive commit message.

@niloc132 niloc132 merged commit 65a0674 into gwtproject:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE when configuration property missing in SuperDevMode
2 participants