Avoid document write in single script linker loading #9847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replaces PR gwtproject#9814 - due to currentScript not being fully supported, wrapped in conditional - fixes issue gwtproject#9797
tbroyer
approved these changes
Aug 15, 2023
niloc132
pushed a commit
that referenced
this pull request
Nov 15, 2023
This PR avoids `document.write` in Chrome browser. It cannot be simply removed for all browsers for reasons mentioned in the code comment (I verified it's still valid in Firefox, didn't check Safari or IE). *Motivation* Same as #9847 -- `document.write` is considered bad for perfomance (flagged by Lighthouse performance audits) and completely forbidden in some contexts (chrome extensions, packaged chrome apps). *Testing* This is part of GeoGebra codebase for a few months (via geogebra/geogebra@ac5c880) and we didn't notice any problems. Co-authored-by: Zbynek Konecny <zbynek@geogebra.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not that this is scoped solely with the
SingleScriptLinker(<add-linker name="sso" />) and not with the other occurrences of document.write