T127 Advanced Search Page #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T527 collections page
…es/scholarspace-hyrax into t127-advanced-search
dolsysmith
reviewed
Apr 26, 2024
There was a problem hiding this comment.
- When changing the sort option (in the dropdown at the bottom of the Advanced Search screen), it triggers the search immediately, which feels a little counterintuitive to me.
Everything else looks good to me. Results are as expected (admittedly using a database with only 20 or so works); the date range works; no errors in the logs.
|
That's a little odd, you're right. I suppose that's the sort behavior elsewhere in blacklight, though. What do you think of removing the option to sort from this page? |
|
I think that makes sense. |
|
Alright, removed it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
To test:
/advancedthrough clicking the "Advanced" button in the navbar.All Fields,Creator,Title,Abstract or Summaryand/orKeyword) - ensure results in catalog match search.Date Createdsearch fields on the left side of the page - ensure results in catalog have dates of creation between the set dates.additional filterssearch fields on the right side of the page to narrow search by facets - ensure results in catalog match search.