Implement retry with backoff to help dodge the 501 error #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opment server as noted in issue#33. Also retries for all other errors. NOT a solution.
sperzion
requested changes
Jun 17, 2020
|
|
||
| /** | ||
| * Upon failure, retry a function that returns a Promise up to a set number of times, | ||
| * with an exponentially increasing delay after each failure |
There was a problem hiding this comment.
Technically, you're doubling the delay each time.
| */ | ||
| function backoff(tries, fn, delay = 500) { | ||
| return fn().catch(error => { | ||
| if (tries > 1) { |
There was a problem hiding this comment.
This is good for this PR, but a slightly more sophisticated approach would be to check what type of error you're getting. If you know it's the intermittent kind, you could do the backoff, whereas if you know it's something that's never going to work no matter how many times you try, you could just stop.
| }) | ||
| .catch(error => console.error(error.message)); | ||
| }); | ||
| backoff(3, fn).catch(error => { |
There was a problem hiding this comment.
So, has this shown to work for you in your dev server?
sperzion
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on the development server as noted in issue#33. Also retries for all other errors. NOT a solution.