Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 feat(Dialog): add forwardRef and custom id to dialog #651

Merged
merged 3 commits into from
Apr 20, 2023

Conversation

MicaelRodrigues
Copy link
Contributor

JIRA Issue

Description 📄

This PR updates Dialog to:

  • Be a forwardRef so the parent can pass a ref object and perform operations on it. One simple use case is to move focus to the modal.
  • Receive a custom id, so we can have multiple dialog content mounted on the same page.

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

[Enter the tips to test this PR]

  • Unit Test
  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots 📸

Screen.Recording.2023-04-20.at.14.08.09.mov
Before After

Copy link
Contributor

@caiotracera caiotracera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@matheushdsbr matheushdsbr merged commit 145a87e into master Apr 20, 2023
@matheushdsbr matheushdsbr deleted the feature/add-ref-to-dialog branch April 20, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants