🚀 fix(Chips): set type in order to prevent unexpected behaviour #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomarcuz
force-pushed
the
fix/prevent-unexpect-behaviour
branch
from
563cf06
to
1a3e7bb
Compare
matheushdsbr
approved these changes
Jun 19, 2023
chady-chaito
approved these changes
Jun 19, 2023
MicaelRodrigues
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📄
When using the Chips component, I expected the default behavior should do a normal click, but as it does not have the type declaration it was doing unexpected behavior like submitting a form as this component is a simple button, under the hood, it is expected to be
type="button"even though is possible to override this config.Platforms 📲
Type of change 🔍
Checklist: 🔍