Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EUEG-2807] - Update Star and StarFilled svg 🚀 #661

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

alycecristines
Copy link
Contributor

these two icons were not working correctly when passing a new color in the fill parameter.

JIRA Issue

Description 📄

Currently, when using the Star and StarFilled icons, it is not possible to change the color using the fill parameter. Upon identifying this problem, a new export of the svg was carried out with the adjustment of the icon and in this way it will now be possible to use this parameter correctly for these icons.

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

[Enter the tips to test this PR]

  • Unit Test
  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots 📸

@alycecristines alycecristines force-pushed the fix/adjust-star-and-star-filled-svg-icons branch from 0456f8f to 1c40d14 Compare June 20, 2023 15:02
@matheushdsbr matheushdsbr merged commit d11b457 into master Jun 20, 2023
@matheushdsbr matheushdsbr deleted the fix/adjust-star-and-star-filled-svg-icons branch June 20, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants