🚀refactor: remove some warnings during development #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
christian-benseler-gympass
changed the title
ericcleao
approved these changes
Aug 21, 2023
rafaelcoletagympass
approved these changes
Aug 21, 2023
christian-benseler-gympass
removed request for
matheushdsbr and
joaopaulonsoares-gympass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📄
During development, there are some warning and errors being thrown to the console.
This PR has 2 fixed for them.
One in the Icon documentation page, where a key was missing to each list child:
The other one was a deprecation warning (from styled-components) in the implementation of the chevron icon used in sidebar tree to show each if each node is open or closed:
Platforms 📲
Type of change 🔍
How Has This Been Tested? 🧪
Manually, browsing the web page (http://localhost:8000/components/icons#web)