Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use poetry v1.2+ #10

Closed
2 tasks done
aryarm opened this issue Nov 21, 2021 · 1 comment
Closed
2 tasks done

use poetry v1.2+ #10

aryarm opened this issue Nov 21, 2021 · 1 comment
Assignees

Comments

@aryarm
Copy link
Member

aryarm commented Nov 21, 2021

  • we should probably use v1.2 of poetry instead of v1.1

v1.2 implements some breaking changes to the structure of the pyproject.toml file. I have taken a look at some of the changes and decided that we will probably need them in the future. For example, one of the changes includes the installation of python packages from Github URLs where the package lives within a subdirectory of the repository, like plink-ng. So it would be best if we moved to v1.2 with haste -- before our project grows to a stage where we need to make lots of changes to the pyproject.toml file

  • you should also update the contributing docs to describe how to install the new poetry version
@aryarm
Copy link
Member Author

aryarm commented Nov 21, 2021

trouble is that I'd like to install v1.2 inside of a conda environment but there is no v1.2 in the conda-feedstock yet - although, there has been mention of it

so now the plan is to

  • fork the feedstock and publish poetry v1.2 to our own conda channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant