-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider restructuring this project as a python library instead of a pipeline #3
Comments
On second thought, it seems like only some of this code would be useful as a command line tool, but the rest (executing FINEMAP and SuSiE and whatnot) fits better in Snakemake (see gymrek-lab/happler#31) new strategy: move everything above this line in the Snakefile into a subcommand within our other repository and then install and call our subcommand from the Snakefile potential drawback: if we call the subcommand multiple times, we'll be duplicating the work of loading the VCF, turning it into a genotype matrix, etc - so maybe we just use our python API from the snakefile instead of calling the subcommand. |
ok, we met with everyone on monday to hash this out
@mlamkin7, what do you think? |
depending on how our needs pan out, we might prefer a command line method, instead
The text was updated successfully, but these errors were encountered: